Add correctly spelled playwright_repo_name#31
Open
mrdomino wants to merge 2 commits intomrmeku:mainfrom
Open
Conversation
Adds a new `playwright_repo_name` argument to `playwright_browser_matrix`, making both it and the old `playright_repo_name` optional but failing unless one is specified. If both are specified, defaults to the new one. This does reorder positional arguments, so it is possible that this could break some users, but seemed better than just renaming the argument name and breaking everyone.
Author
|
NB. I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
playwright_repo_nameargument toplaywright_browser_matrix, making both it and the oldplayright_repo_nameoptional but failing unless one is specified. If both are specified, defaults to the new one.This does reorder positional arguments, so it is possible that this could break some users, but seemed better than just renaming the argument name and breaking everyone.
#26